Skip to content

expo update is broken due to #28115 and #27404 #28488

@TNAJanssen

Description

@TNAJanssen

Current Behavior

› Installing 1 SDK 51.0.0 compatible native module using npm

NX Cannot read properties of undefined (reading 'trim')

TypeError: Cannot read properties of undefined (reading 'trim')
at /path/node_modules/@expo/package-manager/build/node/NpmPackageManager.js:80:22
at Array.map ()
at NpmPackageManager.parsePackageSpecs (/path/node_modules/@expo/package-manager/build/node/NpmPackageManager.js:79:14)
at NpmPackageManager.addAsync (/path/node_modules/@expo/package-manager/build/node/NpmPackageManager.js:34:56)
at installPackagesAsync (/path/node_modules/@expo/cli/build/src/install/installAsync.js:178:30)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async installAndUpdatePackageJson (/path/node_modules/@nx/expo/src/executors/install/install.impl.js:33:5)
at async buildExecutor (/path/node_modules/@nx/expo/src/executors/update/update.impl.js:13:9)
at async getLastValueFromAsyncIterableIterator (/path/node_modules/nx/src/utils/async-iterator.js:15:19)
at async iteratorToProcessStatusCode (/path/node_modules/nx/src/command-line/run/run.js:39:25)

Expected Behavior

› Installing 1 SDK 51.0.0 compatible native module using npm

npm install

GitHub Repo

No response

Steps to Reproduce

  1. create monorepo
  2. install expo-updates
  3. run nx update
  4. see error

Nx Report

NX Report complete - copy this into the issue template

Node : 22.9.0
OS : darwin-arm64
Native Target : aarch64-macos
npm : 10.9.0

nx (global) : 20.0.0
nx : 20.0.1
@nx/js : 20.0.1
@nx/jest : 20.0.1
@nx/eslint : 20.0.1
@nx/workspace : 20.0.1
@nx/cypress : 20.0.1
@nx/devkit : 20.0.1
@nx/eslint-plugin : 20.0.1
@nx/expo : 20.0.1
@nx/plugin : 20.0.1
@nx/react : 20.0.1
@nx/rollup : 20.0.1
@nx/vite : 20.0.1
@nx/web : 20.0.1
@nx/webpack : 20.0.1
typescript : 5.3.3

Registered Plugins:
@nx/vite/plugin
@nx/eslint/plugin
@nx/cypress/plugin
@nx/expo/plugin

Failure Logs

No response

Package Manager Version

10.9.0

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

It does not check if the value is undefined so the options get generated as --force, undefined. This breaks the command as undefined.trim does not exist.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions