-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Comparing changes
Open a pull request
base repository: nrwl/nx
base: 22.2.6
head repository: nrwl/nx
compare: 22.2.7
- 13 commits
- 27 files changed
- 16 contributors
Commits on Dec 16, 2025
-
feat(nx-plugin): allow customizing the location of the companion E2E …
…project (#32073) Fixes #32069 <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Colum Ferry <cferry09@gmail.com> (cherry picked from commit af003c1)
Configuration menu - View commit details
-
Copy full SHA for 46f5766 - Browse repository at this point
Copy the full SHA 46f5766View commit details -
chore(nx-dev): update agent files (#33883)
update claude/agent.md with info about how to use docs (cherry picked from commit db33a7b)
Configuration menu - View commit details
-
Copy full SHA for 9e36745 - Browse repository at this point
Copy the full SHA 9e36745View commit details -
fix(node): use @swc/helpers instead of tslib when compiler is swc (#3…
…3885) When using `@nx/node:library` generator with `--compiler=swc`, the generator was incorrectly adding `tslib` as a dependency instead of `@swc/helpers`. This change fixes two issues: 1. Pass the correct bundler (matching the compiler) to jsLibraryGenerator so it adds the correct helper dependency to the project's package.json 2. Update ensureDependencies to only add tslib when compiler is tsc Fixes #31202 (cherry picked from commit 3db0fb2)
Configuration menu - View commit details
-
Copy full SHA for b5e2b87 - Browse repository at this point
Copy the full SHA b5e2b87View commit details -
chore(misc): add agents.md and gemini to codeowners (#33886)
(cherry picked from commit 497345a)
Configuration menu - View commit details
-
Copy full SHA for afccbfd - Browse repository at this point
Copy the full SHA afccbfdView commit details -
docs(nx-cloud): fix references to metrics enablement (#33888)
## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Update references to disablement variable for metrics collection for Nx Cloud enterprise users. --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> (cherry picked from commit 4931fbf)
Configuration menu - View commit details
-
Copy full SHA for df1af4f - Browse repository at this point
Copy the full SHA df1af4fView commit details -
cleanup(gradle): fix failing nightly (#33884)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit e7758aa)
Configuration menu - View commit details
-
Copy full SHA for 8823c59 - Browse repository at this point
Copy the full SHA 8823c59View commit details -
docs(core): add examples for
dependentTasksOutputFiles(#33870)(cherry picked from commit 80501c9)
Configuration menu - View commit details
-
Copy full SHA for 3588d97 - Browse repository at this point
Copy the full SHA 3588d97View commit details -
chore(repo): remove legacy community/approved-plugins.json file (#33869)
use astro-docs/src/content/approved-community-plugins.json instead. Fixes DOC-363 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: barbados-clemens <barbados-clemens@users.noreply.github.com> (cherry picked from commit 7d1ea67)
Configuration menu - View commit details
-
Copy full SHA for 639d27f - Browse repository at this point
Copy the full SHA 639d27fView commit details -
fix(core): display task output in TUI when native command runner is d…
…isabled (#33881) ## Current Behavior When `NX_NATIVE_COMMAND_RUNNER=false` is set, tasks running in the TUI don't display any output in the terminal pane. The pane remains empty even though the task is running. ## Expected Behavior Task output is displayed in the TUI terminal pane regardless of the `NX_NATIVE_COMMAND_RUNNER` setting. ## Related Issues Fixes #32803 (cherry picked from commit d61ae25)
Configuration menu - View commit details
-
Copy full SHA for 27e1f4c - Browse repository at this point
Copy the full SHA 27e1f4cView commit details -
fix(web): update e2e test regex for SWC decorator metadata (#33892)
## Current Behavior The e2e test `should emit decorator metadata when using --compiler=swc` fails because the regex `/Foo=.*?_decorate/` expects the old transpiled output format where classes were assigned to variables. ## Expected Behavior The test should pass by matching the current SWC output format which uses native ES class syntax. ## Solution Updated the regex from `/Foo=.*?_decorate/` to `/class Foo.*_ts_metadata/` which: - Matches `class Foo` (native ES class syntax) - Verifies `_ts_metadata` is present (decorator metadata) (cherry picked from commit 4ebbe97)
Configuration menu - View commit details
-
Copy full SHA for 8e08403 - Browse repository at this point
Copy the full SHA 8e08403View commit details -
fix(core): prevent pinning the same task in multiple panes in the tui (…
Configuration menu - View commit details
-
Copy full SHA for fb88e71 - Browse repository at this point
Copy the full SHA fb88e71View commit details -
docs(core): document argv in task execution hook contexts (#33322)
The `argv` field was already implemented in `PreTasksExecutionContext` and `PostTasksExecutionContext` but lacked tests and documentation for plugin authors to discover and use it. ## Changes - **Added unit tests** (`packages/nx/src/daemon/server/handle-tasks-execution-hooks.spec.ts`) validating that `argv` flows correctly through hook handlers for different command patterns (direct, affected, run-many) - **Enhanced existing documentation** in `astro-docs/src/content/docs/extending-nx/task-running-lifecycle.mdoc` with a new section covering: - Context property definitions showing the `argv` field - Examples showing how to detect command types (direct execution, affected, run-many) - Example demonstrating conditional analytics based on the original command - Common command patterns reference - Best practices for defensive argv parsing ## Usage ```typescript import type { NxPlugin, PostTasksExecutionContext } from '@nx/devkit'; export const myPlugin: NxPlugin = { name: 'my-plugin', postTasksExecution: async (options, context: PostTasksExecutionContext) => { // Distinguish between nx build my-app vs nx affected -t build if (context.argv.includes('affected')) { console.log('Running in affected mode'); } } }; ``` Fixes https://linear.app/nxdev/issue/NXC-3382/add-contextargv-to-task-execution-hook-contexts <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > Issue Title: Add context.argv to task execution hook contexts > Issue Description: Expose the original CLI arguments on the plugin worker so hooks can distinguish how execution was started (e.g., `nx build nx-api` vs `nx affected -t build`). Proposal: include the invoking argv on the hook context (e.g., `context.argv`). > Fixes https://linear.app/nxdev/issue/NXC-3382/add-contextargv-to-task-execution-hook-contexts > > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > [https://github.com/nrwl/nx](https://github.com/nrwl/nx) > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > Aha! that worked - so you can tell it to assign to copilot instead of "me and copilot" > > Comment by User d484ef82-7f7d-4a95-be09-9d82ca3905dc: > 📋 I wasn't able to determine which GitHub repository to work in. > > I think it's one of these, but can you tell me which one is right? > > Comment by User : > Created issue [NXC-3382](https://linear.app/nxdev/issue/NXC-3382/add-contextargv-to-task-execution-hook-contexts) > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > This comment thread is synced to a corresponding [thread in Slack](https://nrwl.slack.com/archives/C070BJ2JYLW/p1761928859857989?thread_ts=1761928859.857989&cid=C070BJ2JYLW). All replies are displayed in both locations. > > Comment by User : > This thread is for an agent session with githubcopilot. > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > @linear make a ticket and assign it to copilot > > Comment by User f5ae6d50-28e9-4ee7-ad51-3da8208d5914: > Makes sense to me > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > Sure, context.argv? > > Comment by User f5ae6d50-28e9-4ee7-ad51-3da8208d5914: > We can add them as `argv`? > > Comment by User f5ae6d50-28e9-4ee7-ad51-3da8208d5914: > Yeah they would run on the plugin worker so it's not there > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > @jason we could add `originalArgv` to the contexts? > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > Eh, probably not... they run on the plugin worker > > Comment by User 4215f3ef-50bd-4f09-85a0-b489c88057b6: > Yeah, I don't think the hooks know.... I'd be curious if process.argv would just have that info though > > Comment by User 439b15a6-827b-4258-971a-d86133ad59de: > payfit does > > Comment by User 74901385-a023-4825-8470-fe68b1b55664: > I can’t see anything about that in the docs - so I would assume the hooks are agnostic to how the tasks were triggered? > > Comment by User 74901385-a023-4825-8470-fe68b1b55664: > so they’re asking is there’s a way to tell the difference between `nx build nx-api` or `nx affected -t build` in the task hook? > > Comment by User 74901385-a023-4825-8470-fe68b1b55664: > > I’ve been playing around with the Task Execution Hooks, specifically the postTasksExecution hook, and I think it will be really useful for me to grab some detailed metrics for our specific use cases. > > What I feel like it’s missing is a way to see what command actually started the task execution, whether it was a specific target or an affected command. As long as it was a specific target, I think the tasks are sorted in order so the last taskResult will probably be the actual target of the command but for affected it seems a bit more random what the last result will be. > > Is there a way to know exactly which command kicked off the ‘task execution’? > > </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AgentEnder <6933928+AgentEnder@users.noreply.github.com> Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com> Co-authored-by: Caleb Ukle <caleb@nrwl.io> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com> (cherry picked from commit ffc5f69)Configuration menu - View commit details
-
Copy full SHA for fa4f613 - Browse repository at this point
Copy the full SHA fa4f613View commit details -
fix(core): reduce error rate with dir validation and add more debuggi…
…ng data (#33887) This PR adds a validation to the directory prompt, so users should not hit the error as often. Only possible now if they pass the arg from CLI _and_ they are in non-interactive mode. We also added some more data to help debug problems, such as node version, template/preset chosen, etc. And updated the message in "custom" preset prompt to align with the more effective "full platform" prompt. Note: Also update the error message (if it hits) to be the same in new flow and old flow. ## Related Issue(s) Closes NXC-3624 --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> (cherry picked from commit cf7ecc9)
Configuration menu - View commit details
-
Copy full SHA for 34b0746 - Browse repository at this point
Copy the full SHA 34b0746View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 22.2.6...22.2.7