Merged
Conversation
2439269 to
f792f72
Compare
wraithgar
reviewed
Dec 1, 2023
wraithgar
previously approved these changes
Dec 1, 2023
Member
wraithgar
left a comment
There was a problem hiding this comment.
Approved w/ a take-it-or-leave-it question
f792f72 to
3167f51
Compare
wraithgar
approved these changes
Dec 1, 2023
Merged
lukekarrys
pushed a commit
that referenced
this pull request
Dec 1, 2023
🤖 I have created a release *beep* *boop* --- ## [4.21.0](v4.20.0...v4.21.0) (2023-12-01) ### Features * [`2daff23`](2daff23) [#334](#334) use upstream release-please (#334) (@lukekarrys) * [`3d76fc4`](3d76fc4) [#380](#380) release workflow uses composite actions (#380) (@lukekarrys) ### Bug Fixes * [`fbe355c`](fbe355c) [#388](#388) pin release-please version (#388) (@lukekarrys) * [`4fad5d8`](4fad5d8) [#387](#387) make prerelease config switch versioning strategy (#387) (@lukekarrys) * [`c892260`](c892260) [#386](#386) fallback to default release process of 404 from hosted version (#386) (@lukekarrys) * [`9b22b83`](9b22b83) [#384](#384) give release integration workflow correct permissions and secrets (#384) (@lukekarrys) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a tradeoff with our usage of release-please. We are using some
release-pleaseclasses that we import directly from files likeconst { ManifestPlugin } = require('release-please/build/src/plugin.js'). Due to how load bearing our release process is for us, I think it is best to always pin to an exact version and use dependabot PRs to review allrelease-pleasechanges.This PR also updates mocks and snapshots. I was not expecting this to need to be updated but they failed in #385. It's possible that the mock recording or the usage of these mocks inside release-please is non-deterministic. I will keep an eye on these tests and refactor in the future if they turn out to be flaky.