Add overwrite:false file config and better parser matching#323
Merged
lukekarrys merged 2 commits intomainfrom Jul 7, 2023
Merged
Add overwrite:false file config and better parser matching#323lukekarrys merged 2 commits intomainfrom
overwrite:false file config and better parser matching#323lukekarrys merged 2 commits intomainfrom
Conversation
12e70a8 to
51d5f7c
Compare
overwrite:false file config and better parser matching
be89175 to
4de68f5
Compare
By default template-oss allows for written files to be configured on a per-repo basis. This is helpful for different repos to create their own templated files and apply those. With this change, a repo can now set overwrite: false to a templated file and have those updates be applied after the default template-oss changes are made.
4de68f5 to
912f781
Compare
wraithgar
approved these changes
Jul 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
Makes file parsers based on the target filename instead of the source filename. This better matches the expected behavior since the target filename is usually standard (like
package.jsonor.gitignore) but the source often needs to be named differently to avoid issues with those well known filenames.By default template-oss allows for written files to be configured on a per-repo basis. This is helpful for different repos to create their own templated files and apply those. With this change, a repo can now set
overwrite: falseto a templated file and have those updates be applied after the default template-oss changes are made.