Conversation
Removes all usage of `.replace(/#/g, '%23')` for compatibility with the new version This is the code changes from #8112 isloated from the dependency update itself. Closes: npm/npm-package-arg#203 Credit: @TrevorBurnham
f0dffc7 to
45f8dfb
Compare
owlstronaut
approved these changes
Feb 18, 2025
Member
Author
|
As a courtesy I am going to wait for @TrevorBurnham to comment before landing this, since they are the original author. |
Contributor
TrevorBurnham
left a comment
There was a problem hiding this comment.
Glad to help! I left one nitpick comment inline; I didn't review my find-and-replace change very carefully before since I wasn't sure if that was the direction you wanted to go in. All the other changes look good to me.
Member
Author
|
Removal if the vestigial |
Merged
TrevorBurnham
added a commit
to TrevorBurnham/cli
that referenced
this pull request
Feb 18, 2025
Following up on npm#8115. Since `cleanFetchSpec` no longer differs from `fetchSpec`, it's no longer needed.
wraithgar
pushed a commit
that referenced
this pull request
Feb 18, 2025
Following up on #8115. Since `cleanFetchSpec` no longer differs from `fetchSpec`, it's no longer needed. cc @wraithgar
This was referenced Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #8112