Conversation
Setting `tag` in `publishConfig` constitutes a "non default" scenario.
946fba0 to
5284ca3
Compare
5284ca3 to
1630ade
Compare
hashtagchris
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs with how publish checks the highest semver version of existing packages.
First, it allows for the presence of
publishConfig.tagto be considered "not default", allowing publish in that situation.Second, it disregards deprecated versions from consideration when finding if there are any higher versions extant.
Other commits in this PR updates
@npmcli/eslint-configand removes some max-len bypasses that are no longer needed thanks to that update.Finally, a scope was added to the test package name in the publish tests.
References
Closes: #8017