fix: Update publish /w provenance to ignore pkg vis 404#6437
Merged
wraithgar merged 4 commits intonpm:latestfrom May 10, 2023
feelepxyz:feelepxyz/catch-404-visibility-provenance
Merged
fix: Update publish /w provenance to ignore pkg vis 404#6437wraithgar merged 4 commits intonpm:latestfrom feelepxyz:feelepxyz/catch-404-visibility-provenance
wraithgar merged 4 commits intonpm:latestfrom
feelepxyz:feelepxyz/catch-404-visibility-provenance
Conversation
Some registries (e.g. GH packages) require auth to check visibility, and always return 404 when no auth is supplied. In this case we assume the package is always private and require `--access public` to publish. I've also updated this to only perform a visibility check when this is actually needed (i.e. when `provenance` is true and `access` is not `public`). Fixes #6436 Signed-off-by: Philip Harrison <philip@mailharrison.com>
Signed-off-by: Philip Harrison <philip@mailharrison.com>
wraithgar
approved these changes
May 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some registries (e.g. GH packages) require auth to check visibility, and always return 404 when no auth is supplied. In this case we assume the package is always private and require
--access publicto publish.I've also updated this to only perform a visibility check when this is actually needed (i.e. when
provenanceis true andaccessis notpublic).Fixes #6436