fix(arborist): exclude store nodes from :root > * in linked strategy#9096
Merged
wraithgar merged 1 commit intonpm:latestfrom Mar 10, 2026
Merged
Conversation
wraithgar
approved these changes
Mar 10, 2026
manzoorwanijk
added a commit
to manzoorwanijk/npm-cli
that referenced
this pull request
Mar 10, 2026
Merged
manzoorwanijk
added a commit
to manzoorwanijk/npm-cli
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In continuation of our exploration of using
install-strategy=linkedin the Gutenberg monorepo, which powers the WordPress Block Editor.In linked strategy,
npm query ':root > *'returns transitive deps and bare store directory nodes as direct children of root.The
hasParentfunction treats anyisTopnode whoseresolveParentis root as a direct child. In linked mode, all store nodes areisTopand resolve to root viafsParent, so they all match incorrectly.The fix tightens this check to only match if the node has a link in
linksInwhoseparentis the compare node — i.e., there's an actual symlink in the parent'snode_modules/.References
Fixes #9093