chore: fix pruner and reify tests for optional peer deps#8540
Merged
owlstronaut merged 2 commits intonpm:latestfrom Sep 3, 2025
Merged
chore: fix pruner and reify tests for optional peer deps#8540owlstronaut merged 2 commits intonpm:latestfrom
owlstronaut merged 2 commits intonpm:latestfrom
Conversation
owlstronaut
approved these changes
Sep 3, 2025
Merged
Contributor
|
awesome thanks for helping improve this! just one note:
While I agree we don't need all the packages, I think it would be best to have retained a few of the child dependencies because that would show direct-dependencies-of-optional-peer-dependencies are marked as such, and thus are also successfully pruned (ideally it'd also be good to have a test going the other way, with a dependency that is both used by e.g. |
wraithgar
added a commit
that referenced
this pull request
Oct 15, 2025
#8540 removed the bad tests that were hooking into this!
wraithgar
added a commit
that referenced
this pull request
Oct 15, 2025
#8540 removed the tests that were hooking into this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating CI failure in #8537, I found unrelated test failures when running locally on windows.
prune with lockfile with implicit optional peer dependenciesfixed by adding files to fixturenode_modules, avoiding network, also reduced package lock to minimum and removed unhelpful snapshotsmove aside symlink clutterfixed by creating problematic symlink int.testdir()instead of inreifyPackageshook