fix: peer edge crash due to no parent or detached node#8448
Merged
wraithgar merged 2 commits intonpm:latestfrom Aug 28, 2025
Merged
fix: peer edge crash due to no parent or detached node#8448wraithgar merged 2 commits intonpm:latestfrom
wraithgar merged 2 commits intonpm:latestfrom
Conversation
06fb3d8 to
d397d60
Compare
wraithgar
reviewed
Jul 31, 2025
wraithgar
approved these changes
Aug 28, 2025
Merged
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node.parentis resulting innullvalue somewhere in recursive/looped calls to#loadPeerSetmethod in building ideal tree.When circular peer ref of a top level dependency replaced/resolved with different compatible version, it makes top level dependency to be removed from it's parent ( node.parent = null ) since it's been replaced, so no longer need to proceed with further peer set exploration.
fixes: #8261