test: make websocket diagnostics ping-pong ordering deterministic#5222
Merged
Conversation
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5222 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 110 110
Lines 36366 36366
=======================================
Hits 33922 33922
Misses 2444 2444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5200
Rationale
The test created the client
WebSocketbefore subscribing to the diagnostics channels and before registering the serverconnectionhandler. Since the constructor starts the connection immediately, the server could sendping,pong, andclosebefore the test was fully set up.Diagnostics channels are also process-global, so the test should ignore ping/pong events from other websocket instances.
Changes
undici:websocket:pingandundici:websocket:pongbefore creating the clientWebSocket.connectionhandler before creating the clientWebSocket.WebSocketinstance.Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.5