fix(http2): preserve accepted streams after GOAWAY#5090
Merged
Conversation
Assisted-by: openai:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5090 +/- ##
==========================================
- Coverage 93.13% 93.13% -0.01%
==========================================
Files 110 110
Lines 35816 36090 +274
==========================================
+ Hits 33356 33611 +255
- Misses 2460 2479 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcollina
requested changes
Apr 22, 2026
metcoder95
reviewed
Apr 24, 2026
This was referenced Apr 28, 2026
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5089
Rationale
HTTP/2
GOAWAYwithNO_ERRORshould not fail streams the server has already accepted.This change preserves in-flight accepted streams, retries work beyond
lastStreamID, and updates the tests to cover the intended graceful shutdown behavior.Changes
GOAWAYwith code0as informational rather than a socket failurelastStreamIDGOAWAYFeatures
N/A
Bug Fixes
GOAWAYso accepted streams are not failed prematurelyGOAWAYBreaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.4