fix(websocket/stream): only enqueue parsed messages in WebSocketStream#4959
Merged
tsctx merged 1 commit intonodejs:mainfrom Apr 3, 2026
Merged
fix(websocket/stream): only enqueue parsed messages in WebSocketStream#4959tsctx merged 1 commit intonodejs:mainfrom
tsctx merged 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4959 +/- ##
=======================================
Coverage 92.92% 92.93%
=======================================
Files 111 111
Lines 35831 35825 -6
=======================================
- Hits 33297 33293 -4
+ Misses 2534 2532 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KhafraDev
approved these changes
Apr 2, 2026
tsctx
approved these changes
Apr 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #4958
Rationale
WebSocketStream#opened.readableshould only expose parsed WebSocket message payloads.Before this change, the stream could also enqueue raw socket bytes, which intermittently produced malformed text data (for example leading
�) and broke JSON parsing for text frames.Changes
Bug Fixes
WebSocketStreamreadable stream setup.test/websocket/stream/issue-4958.jsto reproduce and guard against the issue.Breaking Changes and Deprecations
None.
Status