Conversation
… for installing/overwriting globals
Uzlopak
commented
Aug 27, 2025
metcoder95
approved these changes
Aug 28, 2025
Merged
slagiewka
pushed a commit
to slagiewka/undici
that referenced
this pull request
Feb 14, 2026
… for installing/overwriting globals (nodejs#4478) * lint: avoid unintented use of globals in code and tests, improve test for installing/overwriting globals * Apply suggestions from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is using the eslint rule
no-restricted-globalsso that we avoid using accidently globals, while we want to use or test our own implementation. Also rewrote the test for theinstall()function.This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status