Skip to content

chore: call super() after type checks#4475

Merged
Uzlopak merged 1 commit intomainfrom
check-first-then-super
Aug 27, 2025
Merged

chore: call super() after type checks#4475
Uzlopak merged 1 commit intomainfrom
check-first-then-super

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 27, 2025

We should call super as the "last" step.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 170592d into main Aug 27, 2025
35 of 36 checks passed
@Uzlopak Uzlopak deleted the check-first-then-super branch August 27, 2025 15:41
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants