Skip to content

fetch: instantiate readableStream in extractBody with sync methods#4350

Merged
mcollina merged 7 commits intomainfrom
make-extractBody-readable-stream-sync
Aug 22, 2025
Merged

fetch: instantiate readableStream in extractBody with sync methods#4350
mcollina merged 7 commits intomainfrom
make-extractBody-readable-stream-sync

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 19, 2025

pull can be sync. start is not necessary, as it will be noop in node core anyway.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@Uzlopak Uzlopak changed the title fetch: instantiate readableStream with sync methods fetch: instantiate readableStream in extractBody with sync methods Jul 19, 2025
@Uzlopak Uzlopak force-pushed the make-extractBody-readable-stream-sync branch from 7d51cff to 390f734 Compare July 19, 2025 09:58
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit aec609b into main Aug 22, 2025
31 of 33 checks passed
@Uzlopak Uzlopak deleted the make-extractBody-readable-stream-sync branch August 27, 2025 22:47
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
…odejs#4350)

* fetch: instantiate readableStream with sync methods

* assign noop

* Apply suggestions from code review

* remove start again

* back to start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants