Skip to content

Extract webidl#4259

Merged
Uzlopak merged 8 commits intomainfrom
extract-webidl
Jun 4, 2025
Merged

Extract webidl#4259
Uzlopak merged 8 commits intomainfrom
extract-webidl

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Jun 3, 2025

Move webidl into its own web folder, write some tests

// https://webidl.spec.whatwg.org/#es-USVString
// TODO: rewrite this so we can control the errors thrown
webidl.converters.USVString = toUSVString
webidl.converters.USVString = (() => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toWellFormed was added in node v20. We don't need the fallback anymore

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will provide this in a follow up

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 4f2c5fe into main Jun 4, 2025
36 of 38 checks passed
@Uzlopak Uzlopak deleted the extract-webidl branch June 4, 2025 14:35
@github-actions github-actions bot mentioned this pull request Jun 26, 2025
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
* chore: extract webidl from fetch folder

* fix import in benchmark

* move benchmark

* fix benchmark

* improve errors

* move USVString functions to webidl

* improve webidl.util.Stringify

* add tests for webidl.converters.boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants