fix(types): add missing DNS interceptor#4024
Merged
mcollina merged 2 commits intonodejs:v6.xfrom Feb 16, 2025
Merged
Conversation
nodejs#3684 has backported the DNS interceptor from nodejs#3490. However, the func that is exported, was not added to TypeScript defs. Co-authored-by: Carlos Fuentes <me@metcoder.dev>
Ethan-Arrowood
approved these changes
Jan 22, 2025
Member
|
Can you add a test for this? we use tsd. |
Author
Added. I wasn't sure how it's supposed to be tested (or where). It could be both tested in Please bear in mind, that the |
metcoder95
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#3684 has backported the DNS interceptor from #3490. However, the func that is exported, was not added to TypeScript defs. Opts and return type were added with the backport already.
Rationale
Allow v6 + TS users to hook the DNS interceptor in.
Changes
Features
Bug Fixes
fix(types): add missing DNS interceptor
Breaking Changes and Deprecations
Status