feat(Backport v6.x): move throwOnError to interceptor#3595
Merged
metcoder95 merged 2 commits intov6.xfrom Sep 18, 2024
Merged
Conversation
(cherry picked from commit 0ea1074)
metcoder95
approved these changes
Sep 12, 2024
Member
|
@metcoder95 can you do a force-push here? This does not seem to trigger CI. |
Contributor
|
I just closed and reopened the PR and that triggered the CI |
Member
|
weird TS issue here: Run npm run test:typescript
> undici@6.19.8 test:typescript
> tsd && tsc test/imports/undici-import.ts --typeRoots ./types && tsc ./types/*.d.ts --noEmit --typeRoots ./types
Error: node_modules/@types/node/module.d.ts(213,13): error TS238[6](https://github.com/nodejs/undici/actions/runs/10861252749/job/30160957939#step:5:7): Overload signatures must all be optional or required.
Error: Process completed with exit code 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 0ea1074 from #3331.