Merged
Conversation
mcollina
reviewed
Aug 30, 2024
| - 'test/autobahn/**' | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write |
Member
There was a problem hiding this comment.
why does this fix the nightly workflow?
I think we should just skip autobahn for nightly instead.
Contributor
Author
There was a problem hiding this comment.
We needed pull-requests write permission when we created a comment in the PR. This was unreliable. So we removed the comment creation but did not remove the permission. Now in a scheduled run, where we call this workflow as reusable workflow, it can not have more perissions than the calling workflow.
We should not skip the autobahn tests. If we had them in the first place, we would have seen the issues with the regressions in node core regarding buffers earlier.
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status