populate defaultValues in webidl dict. converter when passing null or undefined#3518
Merged
KhafraDev merged 2 commits intonodejs:mainfrom Aug 28, 2024
Merged
Conversation
tsctx
reviewed
Aug 27, 2024
tsctx
reviewed
Aug 27, 2024
Member
Author
|
I'm still confused how Request creation (with no RequestInit) is 10-15% faster. |
tsctx
approved these changes
Aug 28, 2024
Member
tsctx
left a comment
There was a problem hiding this comment.
The constructor of Request has an empty object by default, so passing undefined to RequestInit will result in default value.
The performance increase is probably due to the removal of Object.hasOwn.
Member
Author
|
I thought it could be Object.hasOwn, but the extra "overhead" from now having to loop over all of the converters made me think it would be slower. That's why I bothered benchmarking it in the first place. |
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… undefined
The test explains the commit purpose better.
benchmarks/fetch/request-creation.mjswas consistently 10-15% faster. Not sure how @Uzlopak @tsctx, was this a fluke?