fix: remove unnecessary parameters in USVString calls#3467
Merged
Uzlopak merged 1 commit intonodejs:mainfrom Aug 16, 2024
Merged
fix: remove unnecessary parameters in USVString calls#3467Uzlopak merged 1 commit intonodejs:mainfrom
Uzlopak merged 1 commit intonodejs:mainfrom
Conversation
KhafraDev
reviewed
Aug 16, 2024
Member
KhafraDev
left a comment
There was a problem hiding this comment.
I think errors coming from toUSVString should match the rest of the webidl impl. Can toWellFormed throw?
Contributor
Author
|
I dont think that toWellFormed can throw. Its basically a put any garbage in and get a valid/well formed string back. Wdyt? |
Member
|
It technically can throw, but not in any way undici is using it. String.prototype.toWellFormed.call(Symbol() / null / undefined) |
KhafraDev
approved these changes
Aug 16, 2024
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USVString only expects a value parameter.