perf(http2): avoid cloning headers when removing status#5127
Merged
Conversation
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5127 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 110 110
Lines 36117 36119 +2
=======================================
+ Hits 33642 33644 +2
Misses 2475 2475 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
reviewed
Apr 30, 2026
|
|
||
| const { [HTTP2_HEADER_STATUS]: statusCode, ...realHeaders } = headers | ||
| const statusCode = headers[HTTP2_HEADER_STATUS] | ||
| delete headers[HTTP2_HEADER_STATUS] |
Member
There was a problem hiding this comment.
This sits on the critical path, do we have potential perf regression?
Member
Author
There was a problem hiding this comment.
No. This is perf improvement since memory for object realHeaders is not allocated.
metcoder95
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
N/A
Rationale
Avoid cloning HTTP/2 response headers just to remove the
:statuspseudo-header before passing headers to request callbacks.Changes
The response handling now removes
:statusin place instead of using rest destructuring, avoiding an extra headers object allocation for every H2 response and upgrade response.Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.5