Skip to content

fix: make error symbols non enumerable#4531

Merged
mcollina merged 1 commit intomainfrom
make-error-symbols-non-enumerable
Sep 9, 2025
Merged

fix: make error symbols non enumerable#4531
mcollina merged 1 commit intomainfrom
make-error-symbols-non-enumerable

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 8, 2025

Partial PR #4519

I fear that people will get their tests fail, because currently the symbols are enumerable.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 8, 2025

@mcollina

can you please consider reviewing and merging this before we cut a release?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 415c66d into main Sep 9, 2025
32 of 34 checks passed
@mcollina mcollina deleted the make-error-symbols-non-enumerable branch September 9, 2025 07:40
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants