Skip to content

websocket: always emit error event#4521

Merged
KhafraDev merged 1 commit intonodejs:mainfrom
KhafraDev:websocket-socket-error
Sep 6, 2025
Merged

websocket: always emit error event#4521
KhafraDev merged 1 commit intonodejs:mainfrom
KhafraDev:websocket-socket-error

Conversation

@KhafraDev
Copy link
Member

fixes #4487

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks much cleaner

@KhafraDev KhafraDev merged commit 909a584 into nodejs:main Sep 6, 2025
27 of 29 checks passed
@KhafraDev KhafraDev deleted the websocket-socket-error branch September 6, 2025 16:43
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebSocket doesn't dispatch error event when underlying socket is unexpectedly destroyed

2 participants