Merged
Conversation
Contributor
|
Oh, i also created a PR #4400 I actually prefer mine, because it removes a dependency and does not replace it. |
Member
|
Honestly I'd also prefer inlining but just my 50c |
Member
Author
|
I don't have a strong opinion on this; the good reason I found to keep something like But if we feel otherwise, happy to go with an inline version |
KhafraDev
approved these changes
Aug 11, 2025
mcollina
approved these changes
Aug 11, 2025
Member
mcollina
left a comment
There was a problem hiding this comment.
lgtm
The reason we didn't go for inline certs is to avoid the PRs needed to update them every X amount of time + all the false positives that security scanners would generate.
Merged
1 task
slagiewka
pushed a commit
to slagiewka/undici
that referenced
this pull request
Feb 14, 2026
* test: fix key-size pem errors * chore: use @metcoder95/https-pem * fix: ci * fix: ci
mcollina
pushed a commit
that referenced
this pull request
Mar 12, 2026
* test: fix key-size pem errors * chore: use @metcoder95/https-pem * fix: ci * fix: ci (cherry picked from commit 8dd120e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Closes #4156
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status