debugger: various fixes to the debugger and the debugger tests#44359
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Aug 24, 2022
Merged
debugger: various fixes to the debugger and the debugger tests#44359nodejs-github-bot merged 3 commits intonodejs:mainfrom
nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt to alleviate nodejs/build#3014
debugger: decrease timeout used to wait for the port to be free
By default, the debugger would query the specified inspector
sever port to see if it's available before starting the server,
and it would keep retrying until a timeout (previously 9999 ms)
is reached. This timeout seems to be longer than necessary. This
patch decreases the timeout to 3 seconds.
debugger: end connections used to check availability of the port
The debugger check the availability of the specified inspector server
port by trying to connect to it, and retry if the connection can be
established (which means the port is not yet free), but it never ends
those connections. This patch adds code to end the connections after
they are established to avoid taking up more resources than necessary.
test: increase timeout in the debugger tests on Windows
On certain Windows machines it may take longer for the testing
processes to receive outputs from the debugger process. Increasing
the timeout to 15 seconds to avoid failing the tests in those
cases.