Skip to content

debugger: various fixes to the debugger and the debugger tests#44359

Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom
joyeecheung:fix-inspector
Aug 24, 2022
Merged

debugger: various fixes to the debugger and the debugger tests#44359
nodejs-github-bot merged 3 commits intonodejs:mainfrom
joyeecheung:fix-inspector

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung commented Aug 23, 2022

Another attempt to alleviate nodejs/build#3014

debugger: decrease timeout used to wait for the port to be free

By default, the debugger would query the specified inspector
sever port to see if it's available before starting the server,
and it would keep retrying until a timeout (previously 9999 ms)
is reached. This timeout seems to be longer than necessary. This
patch decreases the timeout to 3 seconds.

debugger: end connections used to check availability of the port

The debugger check the availability of the specified inspector server
port by trying to connect to it, and retry if the connection can be
established (which means the port is not yet free), but it never ends
those connections. This patch adds code to end the connections after
they are established to avoid taking up more resources than necessary.

test: increase timeout in the debugger tests on Windows

On certain Windows machines it may take longer for the testing
processes to receive outputs from the debugger process. Increasing
the timeout to 15 seconds to avoid failing the tests in those
cases.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. debugger Issues and PRs related to the debugger subsystem. fast-track PRs that do not need to wait for 72 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants