Merged
Conversation
added 2 commits
February 16, 2024 17:57
gr2m
approved these changes
Feb 17, 2024
Member
gr2m
left a comment
There was a problem hiding this comment.
I tried to understand the origin of the test expecting interceptor.query('foo=bar') to throw an error and yeah, no idea. I agree with your assessment
|
🎉 This PR is included in version 13.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 14.0.0-beta.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2342
@gr2m I'm a bit puzzled here. In the example, it seems like we support this, but we have (an old) test that specifically forbids string as an argument.
Anyway, I think we should support string.