Skip to content

test: improve node16 check in test#2539

Merged
gr2m merged 3 commits intonock:mainfrom
Uzlopak:fix-test-node16
Oct 19, 2023
Merged

test: improve node16 check in test#2539
gr2m merged 3 commits intonock:mainfrom
Uzlopak:fix-test-node16

Conversation

@Uzlopak
Copy link
Copy Markdown
Member

@Uzlopak Uzlopak commented Oct 19, 2023

I checked it now properly.

For some reason parseInt transformed the minor and patch to NaN.

There is no node 16.2.1, so we dont need to check the patch version.

16.2.0 was still using the old error text. 16.3.0 was using the new error text.

@gr2m gr2m changed the title fix: node16 check in test test: improve node16 check in test Oct 19, 2023
@gr2m gr2m merged commit 2a7d907 into nock:main Oct 19, 2023
@Uzlopak Uzlopak deleted the fix-test-node16 branch October 19, 2023 18:07
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 13.3.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants