Conversation
gr2m
left a comment
There was a problem hiding this comment.
everytime nock needed to update lodash was because of some sec. vuln
there is another side to the coin. lodash implements a ton of edge cases that we don't need to worry about and continuously adds improvements. Once we eject it, we will miss out on that and the same sec. vuln that we would be notified about will just exist in nock and we probably won't know.
In this case I'm okay ejecting it though, we don't use much of it, the benefits outweigh the disadvantages.
Thank you for contributing to @nock 💐
|
@all-contributors please add @Uzlopak for code, test, and maintenance |
|
I've put up a pull request to add @Uzlopak! 🎉 |
|
🎉 This PR is included in version 13.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #2530
This PR removes lodash with equivalent functionality.