Skip to content

remove lodash#2529

Merged
gr2m merged 2 commits intonock:mainfrom
Uzlopak:remove-lodash
Oct 19, 2023
Merged

remove lodash#2529
gr2m merged 2 commits intonock:mainfrom
Uzlopak:remove-lodash

Conversation

@Uzlopak
Copy link
Copy Markdown
Member

@Uzlopak Uzlopak commented Oct 17, 2023

Closes #2530

This PR removes lodash with equivalent functionality.

This was referenced Oct 17, 2023
Copy link
Copy Markdown
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everytime nock needed to update lodash was because of some sec. vuln

there is another side to the coin. lodash implements a ton of edge cases that we don't need to worry about and continuously adds improvements. Once we eject it, we will miss out on that and the same sec. vuln that we would be notified about will just exist in nock and we probably won't know.

In this case I'm okay ejecting it though, we don't use much of it, the benefits outweigh the disadvantages.

Thank you for contributing to @nock 💐

@gr2m gr2m merged commit 7bfcb31 into nock:main Oct 19, 2023
@gr2m
Copy link
Copy Markdown
Member

gr2m commented Oct 19, 2023

@all-contributors please add @Uzlopak for code, test, and maintenance

@allcontributors
Copy link
Copy Markdown
Contributor

@gr2m

I've put up a pull request to add @Uzlopak! 🎉

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 13.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove lodash

2 participants