Skip to content

Add Get HypeTrainEvents#113

Merged
nicklaw5 merged 1 commit intonicklaw5:mainfrom
jackmcguire1:hype-trains
Jul 27, 2021
Merged

Add Get HypeTrainEvents#113
nicklaw5 merged 1 commit intonicklaw5:mainfrom
jackmcguire1:hype-trains

Conversation

@jackmcguire1
Copy link
Copy Markdown
Contributor

@jackmcguire1 jackmcguire1 commented Jul 27, 2021 •
edited
Loading

  • introduce GetHypeTrainEvents endpoint
  • supply accommodating test
  • update README.md

NOTES:-

  • docs say to use 'cursor' query parameter for pagination, however this did not achieve expected pagination behavior... it appears that actually the undocumented 'after' query parameter strikes again
  • do the field names of the structs suffice?

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1070206286

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.639%
Totals Coverage Status
Change from base Build 1068395473: 0.03%
Covered Lines: 1064
Relevant Lines: 1101
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 27, 2021

Pull Request Test Coverage Report for Build 1070173092

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.639%
Totals Coverage Status
Change from base Build 1068395473: 0.03%
Covered Lines: 1064
Relevant Lines: 1101
💛 - Coveralls

@jackmcguire1
PROPOSAL: Get HypeTrainEvents
0e3a803 
- introduce get hype train events api
- introduce hype train events test
- update README.md
@nicklaw5 nicklaw5 changed the title PROPOSAL: Get HypeTrainEvents Add Get HypeTrainEvents Jul 27, 2021
nicklaw5
nicklaw5 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@nicklaw5 nicklaw5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nicklaw5 nicklaw5 merged commit cbfb165 into nicklaw5:main Jul 27, 2021
@jackmcguire1 jackmcguire1 deleted the hype-trains branch September 17, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicklaw5 nicklaw5 nicklaw5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackmcguire1 @coveralls @nicklaw5