HOTFIX: Hypetrain progress event unmarshal error struct 'EventSubContribution'#109
Merged
nicklaw5 merged 1 commit intonicklaw5:mainfrom Jul 22, 2021
Merged
Conversation
- The hype train progress event fails to unmarshal into helix's EventSubContribution struct as the 'Total' field is of type string, when it should be int
Pull Request Test Coverage Report for Build 1055490174
💛 - Coveralls |
Scorfly
approved these changes
Jul 22, 2021
nicklaw5
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hype train progress event fails to unmarshal into helix's
EventSubContribution struct as the 'Total' field is of type String
when it should be of type integer.
{ "event": { "top_contributions": [{ "user_id": "602005942", "user_login": "miguell0lxd", "user_name": "miguell0lxd", "type": "bits", "total": 4 }, { "user_id": "616819305", "user_login": "le0n145", "user_name": "le0n145", "type": "subscription", "total": 1000 }], }