Skip to content

Upgrade to Node 20#126

Merged
nick-fields merged 6 commits intonick-fields:masterfrom
prichey:master
Jan 31, 2024
Merged

Upgrade to Node 20#126
nick-fields merged 6 commits intonick-fields:masterfrom
prichey:master

Conversation

@prichey
Copy link
Contributor

@prichey prichey commented Jan 25, 2024 •
edited
Loading

Replace the bullet points below with your answers

Description

Resolves #125

More info here: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Without migrating from @zeit/ncc to @vercel/ncc I got the following, I think due to OpenSSL / Node version mismatch:

$ ncc build src/index.ts && husky install
ncc: Version 0.20.5
ncc: Compiling file index.js
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:68:19)
    at Object.createHash (node:crypto:138:10)
    at hashOf (evalmachine.<anonymous>:1:1478571)
    at module.exports (evalmachine.<anonymous>:1:1480625)
    at runCmd (evalmachine.<anonymous>:1:46940)
    at 819 (evalmachine.<anonymous>:1:43967)
    at __webpack_require__ (evalmachine.<anonymous>:1:216)
    at startup (evalmachine.<anonymous>:1:353)
    at module.exports.8 (evalmachine.<anonymous>:1:385)
    at evalmachine.<anonymous>:1:395 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Testing

  • What tests were added?
    • n/a

@mmkal mmkal mentioned this pull request Jan 25, 2024
Closed
@Jolg42
Copy link

Jolg42 commented Jan 26, 2024

This looks great 🙌🏼 I also noticed all the warnings and it's nice to see this PR 💚

It looks like there is nothing else to do in this PR, right?
Only to get a review from a maintainer?

@prichey prichey marked this pull request as ready for review January 26, 2024 15:18
@prichey
Copy link
Contributor Author

prichey commented Jan 26, 2024

@Jolg42 I'm not actually sure how to vet my changes here. The ncc build succeeded, but other than making sure the test script passes (it does), I'm unsure of the release process.

@Jolg42
Copy link

Jolg42 commented Jan 26, 2024

On your fork, I guess Actions are not enabled because there is no run here:
https://github.com/prichey/retry/actions
That would show if things are working as expected I think.

The easiest would be to have them running here for this PR, I think the GitHub Actions workflow is waiting from the approval from a maintainer to run now.
Maybe @nick-fields could unblock that.

@prichey
Copy link
Contributor Author

prichey commented Jan 26, 2024 •
edited
Loading

Actions are now enabled in my repo, and I have attempted to fix the npm ci issue by regenerating package-lock.json
Most recent run here: https://github.com/prichey/retry/actions/runs/7670357210 (everything passed!)

@prichey prichey changed the title Attempt Node 20 upgrade Upgrade to Node 20 Jan 26, 2024
@prichey prichey mentioned this pull request Jan 26, 2024
Closed
@xavier2k6 xavier2k6 mentioned this pull request Jan 29, 2024
Merged
nick-fields
nick-fields approved these changes Jan 31, 2024
View reviewed changes
Copy link
Owner

@nick-fields nick-fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the submission!

@nick-fields
Copy link
Owner

nick-fields commented Jan 31, 2024 •
edited
Loading

Tests passed, releasing now

@nick-fields nick-fields merged commit 7152eba into nick-fields:master Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nick-fields nick-fields nick-fields approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Node 20

3 participants

@prichey @Jolg42 @nick-fields