Skip to content

feat: expose the agent session ID#237

Merged
bmpngrok merged 1 commit intomainfrom
bmps/session-id
Mar 25, 2026
Merged

feat: expose the agent session ID#237
bmpngrok merged 1 commit intomainfrom
bmps/session-id

Conversation

@bmpngrok
Copy link
Copy Markdown
Contributor

Resolves AGENT-426

Copy link
Copy Markdown
Contributor

@zombiezen zombiezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question:

Comment thread session.go
// ID returns the server-assigned ID of the agent session
// TODO(alan): implement when the server begins setting this value
// ID() string
ID() string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we okay with this being a breaking change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not. Rev to v3?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the bright side, I at least did call this ID everywhere, not Id

@bmpngrok bmpngrok merged commit 89f78c8 into main Mar 25, 2026
5 of 7 checks passed
@bmpngrok bmpngrok deleted the bmps/session-id branch March 25, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants