Fix: allow graph subclasses to have additional arguments#8369
Merged
dschult merged 3 commits intonetworkx:mainfrom Dec 6, 2025
Merged
Fix: allow graph subclasses to have additional arguments#8369dschult merged 3 commits intonetworkx:mainfrom
dschult merged 3 commits intonetworkx:mainfrom
Conversation
amcandio
approved these changes
Dec 5, 2025
rossbar
reviewed
Dec 5, 2025
Co-authored-by: Ross Barnowski <rossbar@caltech.edu>
dschult
approved these changes
Dec 6, 2025
Member
dschult
left a comment
There was a problem hiding this comment.
Looks good!
Thanks @eriknw for the quick fix.
And Thanks @JEZiegler for the report!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #8367
Oops, my bad! Supporting user graph types is kind of important :)
I wasn't sure where to put the test, but it felt important to add at least one test for this.
My bandwidth is limited to make requested changes in a timely manner, so maintainers please feel free to directly update this PR. I'll do my best though and will try to reply to comments/questions.