Skip to content

Update simple_paths.py to improve readability of the BFS.#6273

Merged
MridulS merged 4 commits intonetworkx:mainfrom
SultanOrazbayev:patch-simple-paths-readability
Dec 12, 2022
Merged

Update simple_paths.py to improve readability of the BFS.#6273
MridulS merged 4 commits intonetworkx:mainfrom
SultanOrazbayev:patch-simple-paths-readability

Conversation

@SultanOrazbayev
Copy link
Copy Markdown
Contributor

@SultanOrazbayev SultanOrazbayev commented Dec 10, 2022

Improve readability of the BFS.

Resolves #3912.

@SultanOrazbayev
Update simple_paths.py
5453f43 
Improve readability of the BFS.
@SultanOrazbayev SultanOrazbayev changed the title Update simple_paths.py Update simple_paths.py to improve readability of the BFS. Dec 10, 2022
@SultanOrazbayev
Update simple_paths.py
5271ca3 
remove `value` kwarg.
@SultanOrazbayev SultanOrazbayev marked this pull request as ready for review December 10, 2022 06:25
dschult
dschult reviewed Dec 10, 2022
View reviewed changes
SultanOrazbayev and others added 2 commits December 10, 2022 22:07
@SultanOrazbayev @dschult
Update networkx/algorithms/simple_paths.py
f711f6a 
Co-authored-by: Dan Schult <dschult@colgate.edu>
@SultanOrazbayev
Update simple_paths.py
a611206
@SultanOrazbayev
Copy link
Copy Markdown
Contributor Author

SultanOrazbayev commented Dec 10, 2022

Agree with the change, I hesitated with proposing it initially, but agree that it's more readable that way.

dschult
dschult approved these changes Dec 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

MridulS
MridulS approved these changes Dec 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@MridulS MridulS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SultanOrazbayev!

@MridulS MridulS merged commit 75be68f into networkx:main Dec 12, 2022
@jarrodmillman jarrodmillman added this to the networkx-3.0 milestone Dec 13, 2022
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
@SultanOrazbayev @dschult @MridulS
Update simple_paths.py to improve readability of the BFS. (networkx#6273
a99ab49 
)

* Update simple_paths.py

Improve readability of the BFS.

* Update simple_paths.py

remove `value` kwarg.

* Update networkx/algorithms/simple_paths.py

Co-authored-by: Dan Schult <dschult@colgate.edu>

* Update simple_paths.py

Co-authored-by: Dan Schult <dschult@colgate.edu>
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@SultanOrazbayev @dschult @cvanelteren
Update simple_paths.py to improve readability of the BFS. (networkx#6273
d6b1b4b 
)

* Update simple_paths.py

Improve readability of the BFS.

* Update simple_paths.py

remove `value` kwarg.

* Update networkx/algorithms/simple_paths.py

Co-authored-by: Dan Schult <dschult@colgate.edu>

* Update simple_paths.py

Co-authored-by: Dan Schult <dschult@colgate.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dschult dschult dschult approved these changes

@MridulS MridulS MridulS approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

networkx-3.0

Development

Successfully merging this pull request may close these issues.

Lack of library-wide ordered set hurts readability of algorithms

4 participants

@SultanOrazbayev @dschult @MridulS @jarrodmillman