Skip to content

Fix bug vf2pp is isomorphic issue 6257#6270

Merged
rossbar merged 2 commits intonetworkx:mainfrom
reneechebbo:fix-bug-vf2pp-is-isomorphic-issue-6257
Dec 13, 2022
Merged

Fix bug vf2pp is isomorphic issue 6257#6270
rossbar merged 2 commits intonetworkx:mainfrom
reneechebbo:fix-bug-vf2pp-is-isomorphic-issue-6257

Conversation

@reneechebbo
Copy link
Copy Markdown
Contributor

@reneechebbo reneechebbo commented Dec 10, 2022

fixes #6257

Copy link
Copy Markdown
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks very much!!

@reneechebbo
Copy link
Copy Markdown
Contributor Author

Fantastic! Thanks very much!!

My pleasure!

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch, thanks @reneechebbo !

@rossbar rossbar merged commit 666a37c into networkx:main Dec 13, 2022
@jarrodmillman jarrodmillman added this to the networkx-3.0 milestone Dec 13, 2022
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
* Invert the order of nodes passed to number_of_edges in _consistent_PT in feasibility.py so that the first argument is the
predecessor.

* Add the test provided in the issue 6257 as a unit test
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Invert the order of nodes passed to number_of_edges in _consistent_PT in feasibility.py so that the first argument is the
predecessor.

* Add the test provided in the issue 6257 as a unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

vf2pp_is_isomorphic returns wrong results

4 participants