Conversation
|
@dschult @rossbar @MridulS I normally make the final updates to the release notes when I make the release. Since this PR already renames and the release notes, let's not merge this until I make the release. For now, if anyone else needs to update the release notes, they should make a PR to Mridul's branch. I will make the final pushes to this PR when I make the release and merge it. No one should edit |
dschult
left a comment
There was a problem hiding this comment.
I'm sure we will have to add some to the end of this list. But it looks good to me tat the moment. I've got a few typos and small changes to the commit messages below.
|
It looks like the Perhaps we should remove that line from the release notes -- or figure out a way to count the releases between these releases. |
|
I fixed this locally but didn't push the updated the contribs.py as I haven't really tested it properly. The release notes for 2.8.5 should be fine in this PR. |
|
I've pushed the updated contribs.py file too, it isn't really tested much but it can be used for generating notes by comparing 2 old releases. |
Co-authored-by: Dan Schult <dschult@colgate.edu>
Co-authored-by: Dan Schult <dschult@colgate.edu>
c957de6 to
41d3379
Compare
They were inconsistent with existing release notes, which I will grab from the old releases.
|
I removed the 2.8.6, 2.8.7, and 2.8.8 release notes since they weren't consistent with the actuall 2.8.6, 2.8.7, and 2.8.8 release notes. I am not sure what the issue was but the ones here included things that weren't in the releases. I just need to grab them from the 2.8 release branch, which was the original plan for this release. I also converted the draft release notes back to a dev name, since I normally make the name change at the last moment as part of the release process. I will need to update the release notes then anyway. For the next release, we should stick with the old pattern of just updating the relevant sections in the draft and wait to finalize the release notes and run the contrib.py script when it is time. There is no advantage to run it more than once. I kept the changes to contrib.py for now, but will review whether the scripts still works as expected when I make the release. |
|
Once the tests pass, this is ready to merge and I can start the release process. Thanks! |
* First go through release notes for 3.0 * Add release notes for 2.8.6, 2.8.7 and 2.8.8 * Update doc/release/release_3.0.rst Co-authored-by: Dan Schult <dschult@colgate.edu> * Apply suggestions from code review Co-authored-by: Dan Schult <dschult@colgate.edu> * use contribs.py to find commits b/w any 2 release tags * Update release notes * Remove 2.8.6 through 2.8.8 release notes They were inconsistent with existing release notes, which I will grab from the old releases. Co-authored-by: Dan Schult <dschult@colgate.edu> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
* First go through release notes for 3.0 * Add release notes for 2.8.6, 2.8.7 and 2.8.8 * Update doc/release/release_3.0.rst Co-authored-by: Dan Schult <dschult@colgate.edu> * Apply suggestions from code review Co-authored-by: Dan Schult <dschult@colgate.edu> * use contribs.py to find commits b/w any 2 release tags * Update release notes * Remove 2.8.6 through 2.8.8 release notes They were inconsistent with existing release notes, which I will grab from the old releases. Co-authored-by: Dan Schult <dschult@colgate.edu> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
No description provided.