add missing seed to function called by connected_double_edge_swap#6231
Merged
jarrodmillman merged 1 commit intonetworkx:mainfrom Nov 22, 2022
Merged
add missing seed to function called by connected_double_edge_swap#6231jarrodmillman merged 1 commit intonetworkx:mainfrom
seed to function called by connected_double_edge_swap#6231jarrodmillman merged 1 commit intonetworkx:mainfrom
Conversation
rossbar
reviewed
Nov 22, 2022
rossbar
approved these changes
Nov 22, 2022
jarrodmillman
approved these changes
Nov 22, 2022
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside
connected_double_edge_swap, one call tonx.utils.discrete_sequencedoes not give theseedas input which will mess up trying to make it deterministic by providing a seed.This PR adds
seedto that function call.I haven't been able to make this into a test -- and I spotted it while going through the code... not due to a behavior I didn't expect.