Skip to content

Improve test coverage for Eigenvector centrality #6227

Merged
dschult merged 18 commits intonetworkx:mainfrom
Qudirah:fixes-6226
Dec 13, 2022
Merged

Improve test coverage for Eigenvector centrality #6227
dschult merged 18 commits intonetworkx:mainfrom
Qudirah:fixes-6226

Conversation

@Qudirah
Copy link
Copy Markdown
Contributor

@Qudirah Qudirah commented Nov 19, 2022

fixes #6226

@Qudirah
Copy link
Copy Markdown
Contributor Author

Qudirah commented Nov 21, 2022

@rossbar what do you think?

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Qudirah !

Copy link
Copy Markdown
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Comment on lines +171 to +173
G = nx.Graph()
G.add_nodes_from([1, 2, 3])
G.add_edges_from([(1, 2), (1, 3), (2, 3)])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
G = nx.Graph()
G.add_nodes_from([1, 2, 3])
G.add_edges_from([(1, 2), (1, 3), (2, 3)])
G = nx.Graph([(1, 2), (1, 3), (2, 3)])

Just a more compact setup of the graph... Thanks for this coverage improvement.

@dschult dschult merged commit 9374d1a into networkx:main Dec 13, 2022
@jarrodmillman jarrodmillman added this to the networkx-3.0 milestone Dec 14, 2022
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
Fixes: 6226

* Minor formatting fixups.

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
@Qudirah Qudirah deleted the fixes-6226 branch March 29, 2023 20:11
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Fixes: 6226

* Minor formatting fixups.

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Improve test coverage for Eigenvector centrality

5 participants