Skip to content

Improve coverage for core.py#6116

Merged
MridulS merged 10 commits intonetworkx:mainfrom
Mjh9122:bugfix-for-issue-6115
Nov 14, 2022
Merged

Improve coverage for core.py#6116
MridulS merged 10 commits intonetworkx:mainfrom
Mjh9122:bugfix-for-issue-6115

Conversation

@Mjh9122
Copy link
Copy Markdown
Contributor

@Mjh9122 Mjh9122 commented Oct 22, 2022

Increased Test coverage in test_core.py
Pursuant to issue #6115

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mjh9122 - I took the liberty of applying the suggestions from the core_number test to the onion_layer test as well just for the sake of consistency. LGTM!

@MridulS MridulS changed the title Bugfix for issue 6115 Improve coverage for core.py Nov 14, 2022
@MridulS MridulS merged commit a8c67db into networkx:main Nov 14, 2022
@jarrodmillman jarrodmillman added this to the networkx-3.0 milestone Jan 6, 2023
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
* Added Exception test to test_covering.py

* Completed Testing for covering.py

* Added test and style change

* Increased Coverage in test_core.py

* Changed test_covering.py back to main state

* Update networkx/algorithms/tests/test_core.py

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

* Deleted warning test

* Deleted unused import

* Apply suggestions to onion_layers as well.

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Mjh9122 added a commit to Mjh9122/networkx that referenced this pull request Feb 27, 2023
* Added Exception test to test_covering.py

* Completed Testing for covering.py

* Added test and style change

* Increased Coverage in test_core.py

* Changed test_covering.py back to main state

* Update networkx/algorithms/tests/test_core.py

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

* Deleted warning test

* Deleted unused import

* Apply suggestions to onion_layers as well.

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
@Mjh9122 Mjh9122 deleted the bugfix-for-issue-6115 branch February 27, 2023 15:08
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Added Exception test to test_covering.py

* Completed Testing for covering.py

* Added test and style change

* Increased Coverage in test_core.py

* Changed test_covering.py back to main state

* Update networkx/algorithms/tests/test_core.py

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

* Deleted warning test

* Deleted unused import

* Apply suggestions to onion_layers as well.

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants