Conversation
|
Thanks @nsengiyumva-wilberforce - based on the diff, I suspect there are a couple accidental commits to this branch. Did you intend to also add the line tests to this PR? It might be best to split the test updates out to a separate branch to keep the scope of this PR restricted to the documentation fixes. |
656bac0 to
30b9dc8
Compare
I have removed, I intended them to be part but from your advice, it's better to separate them |
30b9dc8 to
715d874
Compare
|
@rossbar I have addressed your comments here |
rossbar
left a comment
There was a problem hiding this comment.
Thanks @nsengiyumva-wilberforce , this seems on the right track to me. Rather than continuing to iterate via suggestions, I took the liberty of pushing up a few tweaks, including making similar changes to the MultiDiGraph.in_edges docstring.
I'm ambivalent about adding the Examples section as I'm not sure it helps address the original confusion, but that's not a blocker for me.
Thanks for the updates!
Welcome |
* Improve documentation for the View classes * space removed * use G instead of g * update the line a few above to in_edges : InEdgeView or InEdgeDataView * Minor tweaks to docstring, update summary. * Apply similar changes to MultiDiGraph.in_edges docstring. Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
* Improve documentation for the View classes * space removed * use G instead of g * update the line a few above to in_edges : InEdgeView or InEdgeDataView * Minor tweaks to docstring, update summary. * Apply similar changes to MultiDiGraph.in_edges docstring. Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
* Improve documentation for the View classes * space removed * use G instead of g * update the line a few above to in_edges : InEdgeView or InEdgeDataView * Minor tweaks to docstring, update summary. * Apply similar changes to MultiDiGraph.in_edges docstring. Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Improved the docstring description and added examples for how InEdgeView works.
Note: Examples were extracted from discussions that were help in this.
Related to #4765
@MridulS , please review and merge it if possible so that I can complete my application