Resolve NXEP4 with justification for not implementing it.#6617
Merged
jarrodmillman merged 3 commits intonetworkx:mainfrom Apr 4, 2023
Merged
Resolve NXEP4 with justification for not implementing it.#6617jarrodmillman merged 3 commits intonetworkx:mainfrom
jarrodmillman merged 3 commits intonetworkx:mainfrom
Conversation
dschult
approved these changes
Apr 4, 2023
Member
dschult
left a comment
There was a problem hiding this comment.
This looks good to me! It captures my understanding of the discussions.
I have one nit change/suggestion below.
Co-authored-by: Dan Schult <dschult@colgate.edu>
The title is long and makes the table of contents look sloppy. I think the shorter name is clear and given the text it shouldn't cause confusion. @rossbar Feel free to remove this commit, if you prefer.
jarrodmillman
approved these changes
Apr 4, 2023
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 13, 2023
) * Resolve NXEP4 with justification for not implementing it. * Update doc/developer/nxeps/nxep-0004.rst Co-authored-by: Dan Schult <dschult@colgate.edu> * Update nxep-0004.rst The title is long and makes the table of contents look sloppy. I think the shorter name is clear and given the text it shouldn't cause confusion. @rossbar Feel free to remove this commit, if you prefer. --------- Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com> Co-authored-by: Dan Schult <dschult@colgate.edu>
dschult
added a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
) * Resolve NXEP4 with justification for not implementing it. * Update doc/developer/nxeps/nxep-0004.rst Co-authored-by: Dan Schult <dschult@colgate.edu> * Update nxep-0004.rst The title is long and makes the table of contents look sloppy. I think the shorter name is clear and given the text it shouldn't cause confusion. @rossbar Feel free to remove this commit, if you prefer. --------- Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com> Co-authored-by: Dan Schult <dschult@colgate.edu>
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
) * Resolve NXEP4 with justification for not implementing it. * Update doc/developer/nxeps/nxep-0004.rst Co-authored-by: Dan Schult <dschult@colgate.edu> * Update nxep-0004.rst The title is long and makes the table of contents look sloppy. I think the shorter name is clear and given the text it shouldn't cause confusion. @rossbar Feel free to remove this commit, if you prefer. --------- Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com> Co-authored-by: Dan Schult <dschult@colgate.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some text to the discussion section of NXEP4 to capture the conversations at the last several community meetings.
To summarize: I propose not to implement NXEP4 as described, as NetworkX would lose strict stream-compatibility using the new
np.random.Generatoras the default in thenx.random_statedecorators.