Better default alpha value for viz attributes in gexf writer#6612
Merged
dschult merged 2 commits intonetworkx:mainfrom Apr 3, 2023
Merged
Better default alpha value for viz attributes in gexf writer#6612dschult merged 2 commits intonetworkx:mainfrom
dschult merged 2 commits intonetworkx:mainfrom
Conversation
Co-authored-by: Dan Schult <dschult@colgate.edu>
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 13, 2023
…x#6612) * Add test that fails with current default ('None') * Update default alpha value. Co-authored-by: Dan Schult <dschult@colgate.edu> --------- Co-authored-by: Dan Schult <dschult@colgate.edu>
dschult
added a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
…x#6612) * Add test that fails with current default ('None') * Update default alpha value. Co-authored-by: Dan Schult <dschult@colgate.edu> --------- Co-authored-by: Dan Schult <dschult@colgate.edu>
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…x#6612) * Add test that fails with current default ('None') * Update default alpha value. Co-authored-by: Dan Schult <dschult@colgate.edu> --------- Co-authored-by: Dan Schult <dschult@colgate.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6443 with @dschult 's fix. The added test should make clear the motivation for this change - this test fails on
maindue to'None'being given as the default.