Allows to override date-time and duration validators#787
Merged
stevehu merged 1 commit intonetworknt:masterfrom May 26, 2023
Merged
Allows to override date-time and duration validators#787stevehu merged 1 commit intonetworknt:masterfrom
stevehu merged 1 commit intonetworknt:masterfrom
Conversation
MikelAlejoBR
pushed a commit
to MikelAlejoBR/event-schemas-java
that referenced
this pull request
May 26, 2023
Josejulio realized that there is an issue with the "json-schema-validator"[1] dependency we depend on. Basically the custom formatters are not being honored, and that causes some date times to not be read as expected. Josejulio is already working on a fix[2], but in the meantime we will downgrade the library we depend on to a previous version. [1]: networknt/json-schema-validator#784 [2]: networknt/json-schema-validator#787
This was referenced May 26, 2023
josejulio
pushed a commit
to RedHatInsights/event-schemas-java
that referenced
this pull request
May 26, 2023
Josejulio realized that there is an issue with the "json-schema-validator"[1] dependency we depend on. Basically the custom formatters are not being honored, and that causes some date times to not be read as expected. Josejulio is already working on a fix[2], but in the meantime we will downgrade the library we depend on to a previous version. [1]: networknt/json-schema-validator#784 [2]: networknt/json-schema-validator#787 Co-authored-by: Mikel Alejo <>
Contributor
Author
Contributor
|
@josejulio I have released 1.0.83, and it will fix the issue. Thanks a lot for your help. |
Contributor
Author
awesome, thank you! |
|
Thank you @josejulio and @stevehu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #784