Skip to content

Allow walking of schema for items keyword when non-array node is provided#786

Merged
stevehu merged 1 commit intonetworknt:masterfrom
anjnerajat:issue-785
May 25, 2023
Merged

Allow walking of schema for items keyword when non-array node is provided#786
stevehu merged 1 commit intonetworknt:masterfrom
anjnerajat:issue-785

Conversation

@anjnerajat
Copy link
Copy Markdown
Contributor

Resolves #785

Fixing ItemsValidator202012 walk flow.
Making UnevaluatedProperties CollectorContext's key public as was in 1.0.76.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #786 (b3efd56) into master (f09740a) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master     #786      +/-   ##
============================================
- Coverage     74.87%   74.83%   -0.04%     
  Complexity     1191     1191              
============================================
  Files           122      122              
  Lines          4103     4105       +2     
  Branches        790      790              
============================================
  Hits           3072     3072              
- Misses          705      707       +2     
  Partials        326      326              
Impacted Files Coverage Δ
...ava/com/networknt/schema/ItemsValidator202012.java 37.28% <0.00%> (-1.31%) ⬇️
...tworknt/schema/UnevaluatedPropertiesValidator.java 95.00% <ø> (ø)

@stevehu stevehu requested a review from fdutton May 25, 2023 21:41
@stevehu stevehu merged commit de1cb89 into networknt:master May 25, 2023
@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented May 25, 2023

@anjnerajat Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ItemsValidator202012 doesn't walk for non-array nodes

3 participants