Skip to content

Adds support for validating idn-hostname and idn-email#775

Merged
stevehu merged 1 commit intomasterfrom
issue774
May 20, 2023
Merged

Adds support for validating idn-hostname and idn-email#775
stevehu merged 1 commit intomasterfrom
issue774

Conversation

@fdutton
Copy link
Copy Markdown
Contributor

@fdutton fdutton commented May 20, 2023

Resolves #774

@fdutton fdutton linked an issue May 20, 2023 that may be closed by this pull request
Add support for validating idn-hostname and idn-email #774
Closed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2023 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.13253% with 42 lines in your changes missing coverage. Please review.

Project coverage is 75.14%. Comparing base (84d8546) to head (73bb35f).
Report is 159 commits behind head on master.

Files Patch % Lines
.../main/java/com/networknt/schema/utils/RFC5892.java 82.69% 3 Missing and 24 partials ⚠️
...va/com/networknt/schema/utils/UnicodeDatabase.java 84.74% 4 Missing and 5 partials ⚠️
...ain/java/com/networknt/schema/utils/UCDLoader.java 75.00% 4 Missing and 1 partial ⚠️
...com/networknt/schema/format/IdnHostnameFormat.java 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #775      +/-   ##
============================================
+ Coverage     74.44%   75.14%   +0.69%     
- Complexity     1095     1191      +96     
============================================
  Files           116      122       +6     
  Lines          3863     4108     +245     
  Branches        743      792      +49     
============================================
+ Hits           2876     3087     +211     
- Misses          692      696       +4     
- Partials        295      325      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 48a509b into master May 20, 2023
@stevehu stevehu deleted the issue774 branch May 20, 2023 15:25
@fdutton fdutton mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehu stevehu stevehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for validating idn-hostname and idn-email

3 participants

@fdutton @codecov-commenter @stevehu