Skip to content

Updates NOTICE to comply with section 4d of the Apache License Version 2.0#741

Merged
stevehu merged 1 commit intomasterfrom
issue551
May 2, 2023
Merged

Updates NOTICE to comply with section 4d of the Apache License Version 2.0#741
stevehu merged 1 commit intomasterfrom
issue551

Conversation

@fdutton
Copy link
Copy Markdown
Contributor

@fdutton fdutton commented May 2, 2023

Modifications are based on the instructions found at https://infra.apache.org/licensing-howto.html and using Apache Spark as an example.

Summary of changes:

  • Updated LICENSE, NOTICE and pom.xml
  • Removed code copied from Apache Commons Lang
  • Updated code copied from Apache Commons Validator, removed all modifications and moved into a separate, shaded package
  • Refactored format validators to used the updated, unmodified code from Apache Commons Validator

Resolves #551

…cense Version 2.0

Modifications are based on the instructions found at https://infra.apache.org/licensing-howto.html and using Apache Spark as an example.

Summary of changes:
* Updated LICENSE, NOTICE and pom.xml
* Removed code copied from Apache Commons Lang
* Updated code copied from Apache Commons Validator, removed all modifications and moved into a separate, shaded  package
* Refactored format validators to used the updated, unmodified code from Apache Commons Validator

Resolves #551
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #741 (11925d8) into master (d8c1310) will decrease coverage by 1.61%.
The diff coverage is 62.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             master     #741      +/-   ##
============================================
- Coverage     76.14%   74.54%   -1.61%     
+ Complexity     1057     1052       -5     
============================================
  Files           109      110       +1     
  Lines          3614     3665      +51     
  Branches        711      708       -3     
============================================
- Hits           2752     2732      -20     
- Misses          585      651      +66     
- Partials        277      282       +5     
Impacted Files Coverage Δ
...he/commons/validator/routines/DomainValidator.java 20.79% <ø> (ø)
...va/com/networknt/schema/format/AbstractFormat.java 75.00% <ø> (ø)
...ava/com/networknt/schema/format/PatternFormat.java 100.00% <ø> (ø)
.../java/com/networknt/schema/format/RegexFormat.java 85.71% <ø> (ø)
...n/java/com/networknt/schema/format/TimeFormat.java 84.61% <ø> (ø)
...che/commons/validator/routines/RegexValidator.java 33.89% <36.84%> (ø)
...mmons/validator/routines/InetAddressValidator.java 46.83% <40.00%> (ø)
...che/commons/validator/routines/EmailValidator.java 46.15% <46.15%> (ø)
...n/java/com/networknt/schema/utils/StringUtils.java 50.00% <50.00%> (+22.72%) ⬆️
...com/networknt/schema/format/DateTimeValidator.java 90.90% <71.42%> (ø)
... and 6 more

@stevehu stevehu merged commit 6382ac6 into master May 2, 2023
@stevehu stevehu deleted the issue551 branch May 2, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing attribution to Apache Foundation (needed because of vendored commons-lang3 code)

3 participants