Redis: Correctly release incomplete message on removal when using RedisArrayAggregator#16878
Merged
Conversation
…isArrayAggregator Motivation: The RedisArrayAggregator needs to ensure it releases buffered messages when the handler is removed as otherwise it will result in memory leaks. Modifications: - fire exception when channel is closed while we still aggregate - release messages on handler removal - add unit tests Result: Fix memory leak
Contributor
|
Auto-port PR for 5.0: #16903 |
chrisvest
added a commit
that referenced
this pull request
Jun 4, 2026
… when using RedisArrayAggregator (#16903) Auto-port of #16878 to 5.0 Cherry-picked commit: ced30ad --- Motivation: The RedisArrayAggregator needs to ensure it releases buffered messages when the handler is removed as otherwise it will result in memory leaks. Modifications: - fire exception when channel is closed while we still aggregate - release messages on handler removal - add unit tests Result: Fix memory leak --------- Co-authored-by: Norman Maurer <norman_maurer@apple.com> Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The RedisArrayAggregator needs to ensure it releases buffered messages when the handler is removed as otherwise it will result in memory leaks.
Modifications:
Result:
Fix memory leak