Auto-port 4.1: Fix flaky HTTP/2 test#16348
Merged
Merged
Conversation
Motivation: The `LastInboundHandler.queue` is a plain `ArrayList`, but tests access and modify it from both within event loops and test methods. Modification: Put all accesses in `synchronized` blocks. Result: Accesses to the queue is now thread-safe. No more flaky test failures from unsafe concurrent access to the queue. I considered changing it to a concurrent or blocking queue. However, the logic around `UserEvents` makes this difficult to do while preserving the exact behavior that tests might expect. (cherry picked from commit 98284f5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16342 to 4.1
Cherry-picked commit: 98284f5
Motivation:
The
LastInboundHandler.queueis a plainArrayList, but tests access and modify it from both within event loops and test methods.Modification:
Put all accesses in
synchronizedblocks.Result:
Accesses to the queue is now thread-safe.
No more flaky test failures from unsafe concurrent access to the queue.
I considered changing it to a concurrent or blocking queue. However, the logic around
UserEventsmakes this difficult to do while preserving the exact behavior that tests might expect.